Skip to content

Switch off dynaboxify#7838

Merged
mdellweg merged 1 commit into
pulp:mainfrom
mdellweg:saml2_addendum
Jul 7, 2026
Merged

Switch off dynaboxify#7838
mdellweg merged 1 commit into
pulp:mainfrom
mdellweg:saml2_addendum

Conversation

@mdellweg

@mdellweg mdellweg commented Jul 2, 2026

Copy link
Copy Markdown
Member

This will revent dynaconf from creating their own versions of dicts and lists.

The python saml2 library does not approve of it.

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

This will revent dynaconf from creating their own versions of dicts and lists.

The python saml2 library does not approve of it.
@mdellweg mdellweg marked this pull request as ready for review July 2, 2026 14:28
@pedro-psb

Copy link
Copy Markdown
Member

It's possible it will break some plugin, if for example they access nested settings via dot notation like settings.SOMETHING.key, which now must be settings.SOMETHING["key"].

@mdellweg

mdellweg commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

We discussed the most efficient way to test is to merge it.

@mdellweg mdellweg merged commit a847a39 into pulp:main Jul 7, 2026
13 of 14 checks passed
@mdellweg mdellweg deleted the saml2_addendum branch July 7, 2026 07:11
@mdellweg

mdellweg commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Oh, we are at the cusp of a breaking change release anyway. So now is the time anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants